Fix so window functions are run before any where statement #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using window functions in the where statement for filtering.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 01e3290 | Previous: 22d4209 | Ratio |
|---|---|---|---|
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin |
402028500 ns (± 5153287.315151368) |
458826533.3333333 ns (± 10640413.19005047) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin |
494493100 ns (± 23456714.6544912) |
564994640 ns (± 28550338.329818636) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization |
153231730 ns (± 11859188.990239687) |
169842820 ns (± 7144067.768715523) |
0.90 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation |
159438294.44444445 ns (± 7053451.4679182265) |
171581250 ns (± 12415362.812660772) |
0.93 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation |
1808789850 ns (± 64070904.465968184) |
1982296640 ns (± 123349811.75190067) |
0.91 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum |
365323210 ns (± 12760915.101934414) |
This comment was automatically generated by workflow using github-action-benchmark.
…ojection This is required since the filter removes row
The where filter changes the window, so they must be seperate.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/FlowtideDotNet.AcceptanceTests/WindowFunctionTests.cs:708
- [nitpick] There is an inconsistency in the naming of RowNumberResult properties: earlier properties are accessed using PascalCase (e.g. CompanyId, UserKey) but later referenced in lowercase (e.g. value, userkey, companyId). Consider using consistent naming conventions throughout the test to improve clarity.
.Where(x => x.value == 1)
src/FlowtideDotNet.Substrait/Sql/Internal/SqlSubstraitVisitor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/FlowtideDotNet.AcceptanceTests/WindowFunctionTests.cs:708
- [nitpick] Ensure consistent property naming for RowNumberResult fields; the test uses 'value' in one place and 'userkey'/'companyId' in another, which may reflect an inconsistency in property casing.
.Where(x => x.value == 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using window functions in the where statement for filtering.