Add support for "greatest" scalar function #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows checking which of the values are greatest. This is a scalar function if compared to max which is an aggregate function.
This allows checking which of the values are greatest. This is a scalar function if compared to max which is an aggregate function.
src/FlowtideDotNet.Core/Compute/Columnar/Functions/BuiltInComparisonFunctions.cs
Outdated
Show resolved
Hide resolved
src/FlowtideDotNet.Core/Compute/Columnar/Functions/BuiltInComparisonFunctions.cs
Show resolved
Hide resolved
…arisonFunctions.cs Co-authored-by: Copilot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 1532201 | Previous: 22d4209 | Ratio |
|---|---|---|---|
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin |
409624900 ns (± 10230468.884442959) |
458826533.3333333 ns (± 10640413.19005047) |
0.89 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin |
500926140 ns (± 11886831.12638146) |
564994640 ns (± 28550338.329818636) |
0.89 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization |
150212530 ns (± 18593393.966618598) |
169842820 ns (± 7144067.768715523) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation |
160594444.44444445 ns (± 9154840.01527486) |
171581250 ns (± 12415362.812660772) |
0.94 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation |
1745821250 ns (± 136408493.91410303) |
1982296640 ns (± 123349811.75190067) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum |
369400290 ns (± 17843813.64072403) |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #753