Skip to content

Add support for list sort ascending null last #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Conversation

Ulimo
Copy link
Contributor

@Ulimo Ulimo commented Apr 13, 2025

This fixes #768

@Ulimo Ulimo requested a review from Copilot April 13, 2025 14:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • tests/FlowtideDotNet.ComputeTests/OtherCases/list/list_sort_asc_null_last.test: Language not supported
Comments suppressed due to low confidence (1)

tests/FlowtideDotNet.AcceptanceTests/ListTests.cs:194

  • Consider adding test cases for scenarios where the input list contains null elements to fully validate the 'null last' behavior.
public async Task ListSortAscendingNullLast()

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5c06aad Previous: 22d4209 Ratio
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin 414472220 ns (± 13513092.642059732) 458826533.3333333 ns (± 10640413.19005047) 0.90
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin 508955730 ns (± 26558048.394582763) 564994640 ns (± 28550338.329818636) 0.90
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization 161405790 ns (± 10719172.542012954) 169842820 ns (± 7144067.768715523) 0.95
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation 164420720 ns (± 15397756.117968762) 171581250 ns (± 12415362.812660772) 0.96
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation 1859301290 ns (± 123775921.92456496) 1982296640 ns (± 123349811.75190067) 0.94
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum 384315790 ns (± 16104931.334804809)
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithStructAggregation 1510746410 ns (± 48064196.372703224)

This comment was automatically generated by workflow using github-action-benchmark.

@Ulimo Ulimo merged commit 2b355c9 into main Apr 13, 2025
7 checks passed
@Ulimo Ulimo deleted the 768_list_sorting branch April 13, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for list sorting
1 participant