Skip to content

Add function list_first_difference #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Add function list_first_difference #773

merged 1 commit into from
Apr 13, 2025

Conversation

Ulimo
Copy link
Contributor

@Ulimo Ulimo commented Apr 13, 2025

This fixes #771

@Ulimo Ulimo requested a review from Copilot April 13, 2025 19:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • tests/FlowtideDotNet.ComputeTests/OtherCases/list/list_first_difference.test: Language not supported
Comments suppressed due to low confidence (1)

src/FlowtideDotNet.Core/Compute/Columnar/Functions/BuiltInListFunctions.cs:51

  • [nitpick] Consider renaming parameters 'x' and 'y' to 'firstList' and 'secondList' to improve clarity.
private static IDataValue ListFirstDifference<T1, T2>(T1 x, T2 y)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 57a70df Previous: 22d4209 Ratio
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin 414856500 ns (± 11793153.87580156) 458826533.3333333 ns (± 10640413.19005047) 0.90
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin 492438730 ns (± 26509385.14493185) 564994640 ns (± 28550338.329818636) 0.87
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization 146893933.33333334 ns (± 3999567.807901249) 169842820 ns (± 7144067.768715523) 0.86
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation 163559350 ns (± 10524726.096726276) 171581250 ns (± 12415362.812660772) 0.95
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation 1788901730 ns (± 89596873.34584096) 1982296640 ns (± 123349811.75190067) 0.90
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum 367183880 ns (± 14957402.639703935)
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithStructAggregation 1469117240 ns (± 94728653.55430508)

This comment was automatically generated by workflow using github-action-benchmark.

@Ulimo Ulimo merged commit a538dca into main Apr 13, 2025
7 checks passed
@Ulimo Ulimo deleted the 771_list_first_diff branch April 13, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add list_first_difference function
1 participant