Skip to content

Add support for last_value window function #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

Add support for last_value window function #780

merged 5 commits into from
Apr 16, 2025

Conversation

Ulimo
Copy link
Contributor

@Ulimo Ulimo commented Apr 16, 2025

This fixes #779

@Ulimo Ulimo requested a review from Copilot April 16, 2025 08:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/FlowtideDotNet.Core/Compute/Columnar/Functions/WindowFunctions/LastValueWindowFunction.cs:70

  • [nitpick] Consider renaming the variable 'lowerPreceedingRow' to 'upperPreceedingRow' (or another indicative name) in the upper bound branch to more clearly reflect its purpose.
if (windowFunction.UpperBound is PreceedingRowWindowBound lowerPreceedingRow)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a188edb Previous: 22d4209 Ratio
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin 401505640 ns (± 8274693.0679834485) 458826533.3333333 ns (± 10640413.19005047) 0.88
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin 483420244.4444444 ns (± 16873796.696217414) 564994640 ns (± 28550338.329818636) 0.86
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization 144890200 ns (± 21013864.607563265) 169842820 ns (± 7144067.768715523) 0.85
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation 164302300 ns (± 7067309.701364445) 171581250 ns (± 12415362.812660772) 0.96
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation 1791120840 ns (± 127588427.51687899) 1982296640 ns (± 123349811.75190067) 0.90
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum 369399910 ns (± 9807379.570756344)
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithStructAggregation 1480901130 ns (± 79240914.24384318)

This comment was automatically generated by workflow using github-action-benchmark.

@Ulimo Ulimo merged commit 2914225 into main Apr 16, 2025
7 checks passed
@Ulimo Ulimo deleted the last_value branch April 16, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for last_value window function
1 participant