Skip to content

Fix struct column with null add and insert #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

Ulimo
Copy link
Contributor

@Ulimo Ulimo commented Apr 16, 2025

No description provided.

@Ulimo Ulimo requested a review from Copilot April 16, 2025 19:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Ulimo Ulimo requested a review from Copilot April 16, 2025 19:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the handling of null values in struct columns during add and insert operations. The changes check for null values using value.IsNull and ensure that NullValue.Instance is added to each underlying column when null values are encountered.

  • Modified Add method to check for null values and handle them appropriately.
  • Modified InsertAt method to perform similar null value handling.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fdc7f1a Previous: 22d4209 Ratio
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin 408941080 ns (± 9350724.694648597) 458826533.3333333 ns (± 10640413.19005047) 0.89
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin 514145577.7777778 ns (± 24304418.30890928) 564994640 ns (± 28550338.329818636) 0.91
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization 157265560 ns (± 14717406.614406554) 169842820 ns (± 7144067.768715523) 0.93
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation 166598400 ns (± 17090261.711018678) 171581250 ns (± 12415362.812660772) 0.97
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation 1908074550 ns (± 151477018.23421744) 1982296640 ns (± 123349811.75190067) 0.96
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum 350316650 ns (± 25310061.39644206)
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithStructAggregation 1451564566.6666667 ns (± 43693112.89948909)

This comment was automatically generated by workflow using github-action-benchmark.

@Ulimo Ulimo merged commit 139e24c into main Apr 16, 2025
7 checks passed
@Ulimo Ulimo deleted the struct_column_add_null branch April 16, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant