Fix bug in generic read operator, wrong column count #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong column count was used after 100 events has been sent
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: f93154a | Previous: 22d4209 | Ratio |
|---|---|---|---|
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin |
418318090 ns (± 9219731.848860295) |
458826533.3333333 ns (± 10640413.19005047) |
0.91 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin |
477928230 ns (± 10848379.080156527) |
564994640 ns (± 28550338.329818636) |
0.85 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization |
150477410 ns (± 7647863.215333055) |
169842820 ns (± 7144067.768715523) |
0.89 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation |
149564733.33333334 ns (± 12388994.693779638) |
171581250 ns (± 12415362.812660772) |
0.87 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation |
1836074690 ns (± 97916616.11894807) |
1982296640 ns (± 123349811.75190067) |
0.93 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum |
357764370 ns (± 12633512.605394695) |
||
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithStructAggregation |
1500585770 ns (± 91724652.35814378) |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong column count was used after 100 events has been sent