Sqlstorage retry #812
Merged
Sqlstorage retry #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce Polly-based resilience pipeline for retrying database operations in `BaseSqlRepository` and `SqlServerPersistentStorage`. Add `ResiliencePipeline` property to `SqlServerPersistentStorageSettings` and implement extension methods in `SqlServerStorageExtensionsHelpers`. Update existing async operations to utilize the new pipeline for improved error handling and retries.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 33b9686 | Previous: 22d4209 | Ratio |
|---|---|---|---|
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin |
408538740 ns (± 7964456.241947022) |
458826533.3333333 ns (± 10640413.19005047) |
0.89 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin |
495851570 ns (± 20669608.827175334) |
564994640 ns (± 28550338.329818636) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization |
148185650 ns (± 4844704.478316735) |
169842820 ns (± 7144067.768715523) |
0.87 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation |
171645990 ns (± 12798089.158863608) |
171581250 ns (± 12415362.812660772) |
1.00 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation |
1853463620 ns (± 131747641.62756851) |
1982296640 ns (± 123349811.75190067) |
0.94 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.WindowSum |
377445090 ns (± 16453520.824731978) |
||
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithStructAggregation |
1478522330 ns (± 83089154.77579288) |
This comment was automatically generated by workflow using github-action-benchmark.
…sync version of Read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds resilience pipeline to
SqlServerPersistentStorageSettings. Default value is the same incremental retry policy used for the sql server source.Adds two generic helper extensions to execute in the pipeline for any
Task/Task<T>. Did not add a sync version as outcome only supports atTaskandValueTask.Generally retries are added to
connection.OpenAsyncandtransaction.CommitAsync()/transaction.RollbackAsync().What do we think about it conceptually? A bit uncertain regarding the bulkcopy, if it's a good idea to run that in this way.