Skip to content

[Feature] Implement AdaFactor optimizer #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 12, 2023
Merged

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Feb 12, 2023

Problem (Why?)

Implement AdaFactor optimizer.

Solution (What/How?)

  • Implement AdaFactor optimizer

Other changes (bug fixes, small refactors)

nope

Notes

nope

@kozistr kozistr added the feature New features label Feb 12, 2023
@kozistr kozistr self-assigned this Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (fff34af) to head (0533250).
Report is 1624 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #107    +/-   ##
========================================
  Coverage   99.71%   99.72%            
========================================
  Files          39       40     +1     
  Lines        3125     3236   +111     
========================================
+ Hits         3116     3227   +111     
  Misses          9        9            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozistr kozistr merged commit 32b590f into main Feb 12, 2023
@kozistr kozistr deleted the feature/adafactor-optimizer branch February 12, 2023 14:20
@kozistr kozistr added the documentation Improvements or additions to documentation label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New features size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant