Skip to content

[Fix] __str__ method supposed to be a function, not property #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2023

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Mar 12, 2023

Problem (Why?)

related to #118

Solution (What/How?)

  • remove @property from __str__ method

Other changes (bug fixes, small refactors)

nope

Notes

bump version to v2.5.1

@kozistr kozistr added the bug Something isn't working label Mar 12, 2023
@kozistr kozistr self-assigned this Mar 12, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #119 (fc752c4) into main (edee372) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   99.74%   99.74%   -0.01%     
==========================================
  Files          44       44              
  Lines        3550     3520      -30     
==========================================
- Hits         3541     3511      -30     
  Misses          9        9              
Impacted Files Coverage Δ
pytorch_optimizer/optimizer/adabelief.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adabound.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adafactor.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adai.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adamp.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adams.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adan.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/adapnm.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/alig.py 100.00% <100.00%> (ø)
pytorch_optimizer/optimizer/apollo.py 100.00% <100.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kozistr kozistr merged commit df9e78d into main Mar 12, 2023
@kozistr kozistr deleted the fix/str-method branch March 12, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant