Skip to content

[Feature] Implement OrthoGrad optimizer #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 13, 2025
Merged

[Feature] Implement OrthoGrad optimizer #321

merged 16 commits into from
Jan 13, 2025

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jan 13, 2025

Problem (Why?)

Close #319
Close #320

Solution (What/How?)

  • implement OrthoGrad optimizer

Other changes (bug fixes, small refactors)

N/A

Notes

N/A

@kozistr kozistr added documentation Improvements or additions to documentation feature request Request features labels Jan 13, 2025
@kozistr kozistr self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (61fbbd7) to head (141e01e).
Report is 326 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #321      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         104       105       +1     
  Lines        8134      8168      +34     
===========================================
+ Hits         8132      8168      +36     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 13, 2025
@kozistr kozistr merged commit 5baa713 into main Jan 13, 2025
4 checks passed
@kozistr kozistr deleted the feature/orthogonalize branch January 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request Request features size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grokking at the Edge of Numerical Stability Scaling Exponents Across Parameterizations and Optimizers
1 participant