Crash bad char metric name #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus metric name must match the regex [a-zA-Z_:][a-zA-Z0-9_:]* Before this commit, an invalid metric name was causing a crash. https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
Ensure the Prometheus metric name are respecting Prometheus convention.
prom_metric_name was only changed for _create_prometheus_metric and not _add_prometheus_sample.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
Description:
Special characters in the topic is causing Prometheus exception.
Before the commit:
Crash when topic =
cpu_usages_%CpuAfter the commit:
No crash anymore and
cpu_usages_%Cpuis normalized tocpu_usages_Cpu.