fix for downloading policy-templete zip #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Nandle <[email protected]>
daemon1024
requested changes
Sep 8, 2023
|
@daemon1024 where should we store the zip? |
|
@Prateeknandle I meant that kubearmor-client/recommend/recommend.go Line 108 in 11d6d3e in this line, let's not return error but just log a Warning and continue recommend with old templates |
Signed-off-by: Prateek Nandle <[email protected]>
daemon1024
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed
grabpackage dependency for downloading policy-template zip file.grab.Getgives errorserver returned 403 Forbiddenusing
net/httppackage instead.for ref - https://accuknox.slack.com/archives/C0229TD83RA/p1694106383879899