add log source column in profile #492
Open
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aryan-sharma11 <[email protected]>
PrimalPimmy
reviewed
May 15, 2025
| @@ -411,9 +416,16 @@ func generateRowsFromData(data []pb.Log, Operation string) []table.Row { | |||
| (entry.ContainerName == o1.Container) || | |||
| (len(o1.Namespace) == 0 && len(o1.Pod) == 0 && len(o1.Container) == 0) { | |||
| var p Profile | |||
| var logType string | |||
There was a problem hiding this comment.
Maybe we can add in this condition for namespace and container_name as well? Since they don't exist in Host logs, we can just put them as "--" instead of empty space
Signed-off-by: Aryan-sharma11 <[email protected]>
rksharma95
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add log source column in karmor profile to differentiate between container logs and host logs.
