Skip to content

feat: make priorityClassName configurable #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat: make priorityClassName configurable #480

merged 1 commit into from
Jul 18, 2023

Conversation

endriu0
Copy link
Contributor

@endriu0 endriu0 commented Jul 11, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR makes priorityClassName field configurable for both node / controller. It was added recently but hardcoded to specific name.

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:
This is just allowing overrides for the priorityClassName - since people might have exisiting priorityClasses they want to reuse instead of creating new one.

Does this PR introduce a user-facing change?:

Added option to override priorityClassName for both node and controller.
.Values.node.priorityClassName 
.Values.controller.priorityClassName

Defaulting to the existing `system-cluster-critical`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 11, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: endriu0 / name: Andrzej Piorkowski (f4c2024)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @endriu0!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @endriu0. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 11, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5520209467

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.974%
Totals Coverage Status
Change from base Build 5428362941: 0.0%
Covered Lines: 839
Relevant Lines: 1076
💛 - Coveralls

andyzhangx
andyzhangx reviewed Jul 15, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove v4.4.1 change since v4.4.1 is not released yet; and also add change for csi-snapshot-controller pod, thanks:

https://github.com/kubernetes-csi/csi-driver-nfs/blob/0bd9017bedb4bbe9941c2b72c65a460dc09eb303/charts/latest/csi-driver-nfs/templates/csi-snapshot-controller.yaml#L45C7-L45C24

@andyzhangx andyzhangx changed the title Make priorityClass name overridable feat: make priorityClass name overridable Jul 15, 2023
@andyzhangx andyzhangx changed the title feat: make priorityClass name overridable feat: make priorityClassName configurable Jul 15, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2023
@andyzhangx
Copy link
Member

lgtm, pls squash all commits to one

@endriu0
Make priorityClass name overridable
f4c2024 
Add README entries

Before:

After:

Test:

Address comments

Before:

After:

Test:

Fix the lint error

Before:

After:

Test:
@endriu0 endriu0 force-pushed the prio_class_value branch from b6effe9 to f4c2024 Compare July 17, 2023 15:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2023
@endriu0
Copy link
Contributor Author

endriu0 commented Jul 17, 2023

lgtm, pls squash all commits to one

Thanks - squashed now as well.

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2023
andyzhangx
andyzhangx approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, endriu0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 05b1337 into kubernetes-csi:master Jul 18, 2023
@gclawes
Copy link

gclawes commented Jul 18, 2023

Did this change v4.4.0 in-place? Shouldn't this generate a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@endriu0 @k8s-ci-robot @coveralls @andyzhangx @gclawes @maxflowers89