Skip to content

[WIP] feat: support external resource group #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support external resource group

Which issue(s) this PR fixes:

Fixes #3118

Requirements:

Special notes for your reviewer:

Release note:

feat: support external resource group

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from cvvz and ZeroMagic June 5, 2025 03:15
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2025
@andyzhangx andyzhangx changed the title feat: support external resource group [WIP] feat: support external resource group Jun 5, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-sanity c04d70d link true /test pull-azuredisk-csi-driver-sanity
pull-azuredisk-csi-driver-external-e2e-single-az c04d70d link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess c04d70d link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess
pull-azuredisk-csi-driver-e2e-capz c04d70d link true /test pull-azuredisk-csi-driver-e2e-capz
pull-azuredisk-csi-driver-e2e-capz-vmssflex c04d70d link true /test pull-azuredisk-csi-driver-e2e-capz-vmssflex
pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess c04d70d link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess
pull-azuredisk-csi-driver-e2e-migration c04d70d link true /test pull-azuredisk-csi-driver-e2e-migration
pull-azuredisk-csi-driver-e2e-capz-multi-az c04d70d link true /test pull-azuredisk-csi-driver-e2e-capz-multi-az

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSI controller not able to attach disks to VMs in a different resource group
2 participants