Skip to content

🌱 add webhook flags #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
+22 −3
Merged

🌱 add webhook flags #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df4a4a
chore: add wenhook flags and allow disabling them
defo89 Feb 26, 2025
19635b4
fix linter
defo89 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/cache"
"sigs.k8s.io/controller-runtime/pkg/healthz"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
"sigs.k8s.io/controller-runtime/pkg/webhook"

"sigs.k8s.io/cluster-api-ipam-provider-in-cluster/api/v1alpha1"
"sigs.k8s.io/cluster-api-ipam-provider-in-cluster/api/v1alpha2"
Expand Down Expand Up @@ -65,6 +66,10 @@ func main() {
probeAddr string
watchNamespace string
watchFilter string
webhookPort int
webhookCertDir string
webhookCertName string
webhookKeyName string
)
flag.StringVar(&metricsAddr, "metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
Expand All @@ -74,6 +79,10 @@ func main() {
flag.StringVar(&watchNamespace, "namespace", "",
"Namespace that the controller watches to reconcile cluster-api objects. If unspecified, the controller watches for cluster-api objects across all namespaces.")
flag.StringVar(&watchFilter, "watch-filter", "", "")
flag.IntVar(&webhookPort, "webhook-port", 9443, "Webhook Server port.")
flag.StringVar(&webhookCertDir, "webhook-cert-dir", "/tmp/k8s-webhook-server/serving-certs/", "Webhook cert dir.")
flag.StringVar(&webhookCertName, "webhook-cert-name", "tls.crt", "Webhook cert name.")
flag.StringVar(&webhookKeyName, "webhook-key-name", "tls.key", "Webhook key name.")
flag.Parse()

// klog.Background will automatically use the right logger.
Expand All @@ -89,6 +98,14 @@ func main() {
HealthProbeBindAddress: probeAddr,
LeaderElection: enableLeaderElection,
LeaderElectionID: "7bb7acb4.ipam.cluster.x-k8s.io",
WebhookServer: webhook.NewServer(
webhook.Options{
Port: webhookPort,
CertDir: webhookCertDir,
CertName: webhookCertName,
KeyName: webhookKeyName,
},
),
}

if watchNamespace != "" {
Expand Down Expand Up @@ -137,9 +154,11 @@ func main() {
os.Exit(1)
}

if err := (&webhooks.InClusterIPPool{Client: mgr.GetClient()}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "InClusterIPPool")
os.Exit(1)
if webhookPort != 0 {
if err := (&webhooks.InClusterIPPool{Client: mgr.GetClient()}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "InClusterIPPool")
os.Exit(1)
}
}
//+kubebuilder:scaffold:builder

Expand Down
Loading