🐛 properly handle deletion of IPAddressClaims in ipamutil.ClaimReconciler #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
do-not-merge/hold
schrej
changed the title
|
I've closed the duplicate, but will keep the hold for further internal testing in conjunction with our Infoblox provider. |
schrej
requested changes
Mar 28, 2025
llxp
force-pushed
the
fix/reconcile-delete
branch
from
4d0c99d to
d15f570
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
schrej
changed the title
llxp
force-pushed
the
fix/reconcile-delete
branch
from
d15f570 to
3e32453
Compare
There were two cases where deletion of a claim was reconciled without calling ClaimHandler.ReleaseAddress, which causes issues for providers that manage addresses in external systems.
schrej
force-pushed
the
fix/reconcile-delete
branch
from
3e32453 to
fa644f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is based on the changes from @schrej and fixes a bug, where ReleaseAddress is not getting called during deletion.
Additionally it fixes an error regarding to error handling:
err := errors.New("pool not found")This hides the error of FetchPool(). Instead it should be wrapped/enhanced by the new error.
And changes some behaviour regarding the finalizer patching. The defer is moved down and the finalizer patching is now done explicitly instead of implicitly by the defer.