🌱 e2e: also collect pod logs #3490
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XS
chrischdi
force-pushed
the
pr-debug-ipam-test
branch
from
7b72ddb to
02a87cf
Compare
k8s-ci-robot
added
size/S
chrischdi
force-pushed
the
pr-debug-ipam-test
branch
from
0281072 to
dad710e
Compare
chrischdi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -61,6 +61,13 @@ on_exit() { | |||
|
|
|||
| # Cleanup VSPHERE_PASSWORD from temporary artifacts directory. | |||
| if [[ "${ORIGINAL_ARTIFACTS}" != "" ]]; then | |||
| # unpack pod-logs.tar.gz files to replace secrets in them | |||
There was a problem hiding this comment.
I think this results in a very deep folder hierarchy. In the interest of future us, can we reduce that a bit?
I get this after extract: ./tmp 2/tmp.BAZS1S16eR/clusters/quick-start-l3rsho/machines/quick-start-l3rsho-cp-5x2qt-wfsf5/pod-logs.tar.gz-unpacked/pods/kube-system_etcd-quick-start-l3-wfsf5_6501f15974bbf5a29b9e36b04db38957/etcd.
Ideally kube-system would be top-level in this archive (but just getting rid of *-unpacked and above would be fine as well)
There was a problem hiding this comment.
oh 🤔 good one. Let me check how this came. I did not expect that either.
There was a problem hiding this comment.
Should be good now.
Its now pods/kube-system_etcd-quick-start-l3-wfsf5_6501f15974bbf5a29b9e36b04db38957/etcd
There was a problem hiding this comment.
(I broke it somewhere?!)
chrischdi
added
the
tide/merge-method-squash
|
/cherry-pick release-1.13 |
|
/cherry-pick release-1.12 |
|
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you very much! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 847311a44f4137d6b47670e184edb1880d0a1185
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@chrischdi: new pull request created: #3496 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@chrischdi: new pull request created: #3497 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.11 |
|
@chrischdi: new pull request created: #3499 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Also collect logs from the running pods, but as tarball to save some space.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #