retry failed calls when waiting for namespace ready #3627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test helper NamespacesMustBeReady must retry if fails to list the existing gateways or pods, otherwise it may declare that the namespaces are ready without actually checking them. Change-Id: I358008a9e656735d660719f4fad8dbf38f60fd83
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
|
Mattia is the conformance lead, so assigning him instead. |
|
Thanks for fixing this! /lgtm |
k8s-ci-robot
added
the
lgtm
|
I think @youngnick meant to assign @mlavacca above. /assign @mlavacca |
|
/retry |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
EyalPazz
pushed a commit
to EyalPazz/gateway-api
that referenced
this pull request
Feb 27, 2025
…3627) The test helper NamespacesMustBeReady must retry if fails to list the existing gateways or pods, otherwise it may declare that the namespaces are ready without actually checking them. Change-Id: I358008a9e656735d660719f4fad8dbf38f60fd83
EyalPazz
pushed a commit
to EyalPazz/gateway-api
that referenced
this pull request
Feb 27, 2025
…3627) The test helper NamespacesMustBeReady must retry if fails to list the existing gateways or pods, otherwise it may declare that the namespaces are ready without actually checking them. Change-Id: I358008a9e656735d660719f4fad8dbf38f60fd83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test helper NamespacesMustBeReady must retry if fails to list the existing gateways or pods, otherwise it may declare that the namespaces are ready without actually checking them.
/kind bug
/kind test
/kind flake
/area conformance
/assign @robscott