Skip to content

Promote GEP 3171 - Percentage Based Request mirroring to standard #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

LiorLieberman
Copy link
Member

/kind cleanup
/kind documentation

What this PR does / why we need it:
Promote Percentage Based Request mirroring to standard

Does this PR introduce a user-facing change?:

promote percentage-based-request-mirroring to standard

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@LiorLieberman
Copy link
Member Author

/retest

@LiorLieberman
Copy link
Member Author

LiorLieberman commented Feb 27, 2025

Constantly failed. I did not have time to look deeper, if anyone has any quick hint it may help merging this by the requested timeline.
/cc @robscott

@dprotaso
Copy link
Contributor

I'm running ./hack/update-codegen.sh on your PR and getting changes that match what's in main

Curious why there's a drift in your environment

@dprotaso
Copy link
Contributor

Note: this other PR of mine didn't flag this - #3632

@BenTheElder
Copy link
Member

You should pin the go version https://go.dev/doc/toolchain, so gofmt is consistent.

It looks like this repo more or less has one module, so you can use toolchain in go.mod

@robscott
Copy link
Member

robscott commented Mar 1, 2025

Thanks @LiorLieberman!

For the record, this PR was ready before the deadline but codegen was failing for reasons out of Lior's control (more on that later).

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2025
@BenTheElder
Copy link
Member

#3652 should resolve codegen

@robscott
Copy link
Member

robscott commented Mar 1, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit e7f850d into kubernetes-sigs:main Mar 1, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants