-
Notifications
You must be signed in to change notification settings - Fork 529
Promote GEP 3171 - Percentage Based Request mirroring to standard #3638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote GEP 3171 - Percentage Based Request mirroring to standard #3638
Conversation
/retest |
Constantly failed. I did not have time to look deeper, if anyone has any quick hint it may help merging this by the requested timeline. |
I'm running Curious why there's a drift in your environment |
Note: this other PR of mine didn't flag this - #3632 |
1f1e4a6
to
11c88d2
Compare
You should pin the go version https://go.dev/doc/toolchain, so gofmt is consistent. It looks like this repo more or less has one module, so you can use |
11c88d2
to
e781c5d
Compare
Thanks @LiorLieberman! For the record, this PR was ready before the deadline but codegen was failing for reasons out of Lior's control (more on that later). /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#3652 should resolve codegen |
/hold cancel |
/kind cleanup
/kind documentation
What this PR does / why we need it:
Promote Percentage Based Request mirroring to standard
Does this PR introduce a user-facing change?: