Clarify API docs about priority conflicts #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
npinaeva
moved this to In-Progress-NPEP-Issues
in AdminNetworkPolicyAPI: The road to Beta
danwinship
force-pushed
the
priority-conflict
branch
from
f305fd1 to
aec04c9
Compare
k8s-ci-robot
added
size/M
tssurya
reviewed
Apr 13, 2025
| // If two (or more) policies with the same priority could both match a connection, | ||
| // then the implementation can apply any of the matching policies to the | ||
| // connection, and there is no way for the user to reliably determine which one it | ||
| // will choose. Administrators must be careful about assigning the priorities for |
There was a problem hiding this comment.
Suggested change
| // will choose. Administrators must be careful about assigning the priorities for | |
| // will choose unless the implementation provides a way to do so. Administrators must be careful about assigning the priorities for |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we say "You shouldn't do this... Here's what happens if you do", which is confusing.
Fixes #292