Skip to content

Implement PushToNamedFork in the git v2 client. #30971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2023
Merged

Implement PushToNamedFork in the git v2 client. #30971

merged 2 commits into from
Oct 7, 2023

Conversation

cjwagner
Copy link
Member

@cjwagner cjwagner commented Oct 6, 2023

I think this is a reasonable way to implement this, but I'm definitely open to alternative implementation suggestions. I tried to refactor the logic for the httpResolverFactory into something more readable.

fixes #30937

/assign @airbornepony @timwangmusic
/cc @killianmuldoon

@k8s-ci-robot
Copy link
Contributor

@cjwagner: GitHub didn't allow me to assign the following users: airbornepony.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I think this is a reasonable way to implement this, but I'm definitely open to alternative implementation suggestions. I tried to refactor the logic for the httpResolverFactory into something more readable.

fixes #30937

/assign @airbornepony @timwangmusic
/cc @killianmuldoon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 6, 2023
cjwagner
cjwagner commented Oct 6, 2023
View reviewed changes
prow/git/v2/remote_test.go

for _, testCase := range testCases {
t.Run(testCase.name, func(t *testing.T) {
actual, actualErr := HttpResolver(testCase.remote, testCase.username, testCase.token, "org")()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality that was tested here is well tested by the other test functions in this file. I updated the other test functions with unit cases to cover the new behavior.

@cjwagner cjwagner force-pushed the push-to-named-fork branch from d462274 to 6f48638 Compare October 6, 2023 21:09
@cjwagner cjwagner changed the title Implement PustToNamedFork in the git v2 client. Implement PushToNamedFork in the git v2 client. Oct 6, 2023
airbornepony
airbornepony reviewed Oct 6, 2023
View reviewed changes
@andyzhangx
Copy link
Member

/retest

andyzhangx
andyzhangx approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2f59a2 into kubernetes:master Oct 7, 2023
@MartinForReal
Copy link
Contributor

MartinForReal commented Oct 8, 2023 •
edited
Loading

I'm wondering if we can deploy the prow changes ASAP because cherrypicker is a frequently used utilility. @kubernetes/k8s-infra-group-admins

@airbornepony airbornepony mentioned this pull request Oct 11, 2023
Closed
9 tasks
@cjwagner cjwagner deleted the push-to-named-fork branch January 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airbornepony airbornepony airbornepony left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@andyzhangx andyzhangx

@timwangmusic timwangmusic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cherry-pick bot failing with pushToNamedFork is not implemented in the v2 client
6 participants
@cjwagner @k8s-ci-robot @andyzhangx @MartinForReal @airbornepony @timwangmusic