Skip to content

Add 'FailedToRetrieveImagePullSecret' event examples #41897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add 'FailedToRetrieveImagePullSecret' event examples #41897

merged 1 commit into from
Jul 13, 2023

Conversation

kaisoz
Copy link
Contributor

@kaisoz kaisoz commented Jul 5, 2023

Hi!

This PR aims to fix #41896.

Currently, the 'FailedToRetrieveImagePullSecret' event is logged when a pod references a secret containing registry credentials and the secret doesn't exist. The documentation doesn't mention this event in any of its pages.

This PR aims to amend that by adding examples of what happens in such a case.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kaisoz!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 5, 2023
@kaisoz
Copy link
Contributor Author

kaisoz commented Jul 5, 2023

/assign @sftim

@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a9e4de
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64ad5afc11e2b3000815a0c0
😎 Deploy Preview https://deploy-preview-41897--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

You can tweak the wording if you like.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b0d495d250869b0c8d52792d0c489b12a0fc23e

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim July 6, 2023 09:53
@kaisoz
Copy link
Contributor Author

kaisoz commented Jul 6, 2023 •
edited
Loading

/lgtm

You can tweak the wording if you like.

Commits added. I like the suggestions are they are 😊 . @sftim I think you need to /lgtm again?

sftim
sftim reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6c2594decad8aa48de52f0793af8e8588e60a3d

kundan2707
kundan2707 reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from kundan2707 and sftim July 10, 2023 20:02
@kaisoz
Copy link
Contributor Author

kaisoz commented Jul 10, 2023

@kbhawkey I think I'll need your lgtm now since the bot removed it after the change 😅

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@kaisoz
Copy link
Contributor Author

kaisoz commented Jul 11, 2023

@kbhawkey it seems that tide stil requires the lgtm label :(

/cc @kundan2707 @sftim

@kundan2707
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 11, 2023
@kundan2707
Copy link
Contributor

@kaisoz squash multiple commits into one

@kaisoz kaisoz force-pushed the add-doc-for-missing-ImagePullSecrets branch from 40fc0b7 to 9a9e4de Compare July 11, 2023 13:36
@kaisoz
Copy link
Contributor Author

kaisoz commented Jul 11, 2023

@kaisoz squash multiple commits into one

@kundan2707 done 😊

@mengjiao-liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: be042cb58622d64c801f859a98ab25de68eafefe

@k8s-ci-robot k8s-ci-robot merged commit 866a0d2 into kubernetes:main Jul 13, 2023
richabanker pushed a commit to richabanker/website that referenced this pull request Jul 24, 2023
@kaisoz @richabanker
Add FailedToRetrieveImagePullSecret event description to pull-image-p…
2e713e9 
…rivate-registry (kubernetes#41897)
@kaisoz kaisoz mentioned this pull request Nov 20, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@kundan2707 kundan2707 Awaiting requested review from kundan2707

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

@mengjiao-liu mengjiao-liu

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing mention to the 'FailedToRetrieveImagePullSecret' event
6 participants
@kaisoz @k8s-ci-robot @kbhawkey @kundan2707 @mengjiao-liu @sftim