Skip to content

ci(gha): verify CI stability action #11625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Oct 2, 2024

Checklist prior to review

Introduce GHA action to check CI stability.
It's this #11589 but without me leaving the laptop running the script.

The action runs every 2h outside of working hours during weekdays (feel free to suggest better hours) and every 2h on the weekends. It adds a commit to PRs with ci/verify-stability label. Additionally, if there is ci/verify-stability-merge-master we merge master.

The use case is that we can have a "long-running" PR with both labels so it checks the stability of the current master branch.

You can also do the same but on a PR. Let's say we introduce a risky change. We can remove a label on our long-running PR and instead put ci/verify-stability on the PR with a risky change.

Potential improvements:

  • Instead of every 2h, we could track if the CI run finished and then push another commit to have more runs.
  • It does not work with forks. Not sure if it's even possible, because we push commits to the branch we may not have an access to
  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz jakubdyszkiewicz added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 2, 2024
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 2, 2024 12:21
@jakubdyszkiewicz jakubdyszkiewicz requested review from bartsmykla and lukidzi and removed request for a team October 2, 2024 12:21
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 4d79b39 into kumahq:master Oct 3, 2024
12 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the ci-stability-gha branch October 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants