Disable external links validation on master (#1325)

Author: magicmatatjahu

governance.Jenkinsfile

@@ -23,22 +23,21 @@ podTemplate(label: label) {
                             checkout scm
                         }
 
+
                         stage("validate internal links") {
                             validateLinks('--ignore-external', repositoryName)
                         }
 
-                        if (!isMaster) {
+                        if (isMaster) {
+                            stage("validate external links") {
+                                validateLinks('--ignore-internal', repositoryName)
+                            }
+                        } else {
                             stage("validate external links in changed markdown files") {
                                 def changes = changedMarkdownFiles(repositoryName).join(" ")
                                 validateLinks("--ignore-internal ${changes}", repositoryName)
                             }
                         }
-
-                        if(isMaster || params.TRIGGER_FULL_VALIDATION) {
-                            stage("validate external links") {
-                                validateLinks('--ignore-internal', repositoryName)
-                            }
-                        }
                     }
                 }
             }
@@ -47,7 +46,7 @@ podTemplate(label: label) {
             currentBuild.result = "FAILURE"
             def body = "${currentBuild.currentResult} ${env.JOB_NAME}${env.BUILD_DISPLAY_NAME}: on branch: ${params.GIT_BRANCH}. See details: ${env.BUILD_URL}"
             emailext body: body, recipientProviders: [[$class: 'DevelopersRecipientProvider'], [$class: 'CulpritsRecipientProvider'], [$class: 'RequesterRecipientProvider']], subject: "${currentBuild.currentResult}: Job '${env.JOB_NAME} [${env.BUILD_NUMBER}]'"
-            
+
             if(isMaster) {
                 sendSlackNotification(":hankey-fire:Governance validation failed on `${repositoryName}` repository!\nSee details: ${env.BUILD_URL}console")
             }

orchestrator.Jenkinsfile

@@ -214,7 +214,7 @@ String[] changedProjects() {
                 res.add(allProjects[i])
                 break // already found a change in the current project, no need to continue iterating the changeset
             }
-            if (allProjects[i] == "governance" && allChanges[j].endsWith(".md") && !res.contains(allProjects[i])) {
+            if (env.BRANCH_NAME != 'master' && allProjects[i] == "governance" && allChanges[j].endsWith(".md") && !res.contains(allProjects[i])) {
                 res.add(allProjects[i])
                 break // already found a change in one of the .md files, no need to continue iterating the changeset
             }
@@ -234,7 +234,7 @@ boolean changeIsValidFileType(String change, String project){
 @NonCPS
 String changeset() {
     // on branch get changeset comparing with master
-    if (env.BRANCH_NAME != "master") {
+    if (env.BRANCH_NAME != 'master') {
         echo "Fetching changes between origin/${env.BRANCH_NAME} and origin/master."
         return sh (script: "git --no-pager diff --name-only origin/master...origin/${env.BRANCH_NAME} | grep -v 'vendor\\|node_modules' || echo ''", returnStdout: true)
     }