Skip to content

Disable external links validation on master #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

Disable external links validation on master #1325

merged 1 commit into from
Oct 23, 2018

Conversation

magicmatatjahu
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Disable external links validation on master

Related issue(s)
See also #1290

@magicmatatjahu magicmatatjahu added kind/feature Categorizes issue or PR as related to a new feature. priority/critical Priority indication area/community Related to all activities that are done for Kyma community labels Oct 18, 2018
@magicmatatjahu magicmatatjahu added the area/ci Issues or PRs related to CI related topics label Oct 19, 2018
hudymi
hudymi suggested changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@hudymi hudymi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #1290 all links validation should be disabled on master. Master should be checked only by nightly.

@hudymi
Copy link
Contributor

hudymi commented Oct 20, 2018

It should be configured in orchestrator.Jenkinsfile as orchestrator is responsible for starting jobs. Changes in governance.Jenkinsfile should be probably reverted.

@magicmatatjahu magicmatatjahu force-pushed the nightly-governance branch 4 times, most recently from dfda4ec to c0587ea Compare October 22, 2018 07:56
@magicmatatjahu magicmatatjahu merged commit 014de52 into kyma-project:master Oct 23, 2018
@magicmatatjahu magicmatatjahu deleted the nightly-governance branch October 23, 2018 13:03
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
@hudymi
Mark jobs as required (kyma-project#1325)
5a3f01f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudymi hudymi hudymi approved these changes

@lilitgh lilitgh lilitgh approved these changes

@a-thaler a-thaler Awaiting requested review from a-thaler

@aerfio aerfio Awaiting requested review from aerfio

@akucharska akucharska Awaiting requested review from akucharska

@clebs clebs Awaiting requested review from clebs

@mjasinski5 mjasinski5 Awaiting requested review from mjasinski5

@pkosiec pkosiec Awaiting requested review from pkosiec

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

Assignees
No one assigned
Labels
area/ci Issues or PRs related to CI related topics area/community Related to all activities that are done for Kyma community kind/feature Categorizes issue or PR as related to a new feature. priority/critical Priority indication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @hudymi @lilitgh