Skip to content

Improve logs of central-application-gateway #17265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 5 tasks
Disper opened this issue Apr 7, 2023 · 10 comments · Fixed by #18016
Closed
4 of 5 tasks

Improve logs of central-application-gateway #17265

Disper opened this issue Apr 7, 2023 · 10 comments · Fixed by #18016
Assignees
Labels
area/application-connector Issues or PRs related to application connectivity
Milestone

Comments

@Disper
Copy link
Member

Disper commented Apr 7, 2023

Description

@ebensom pointed out that logs in central-application-gateway should be improved.

Acceptance criteria:

  • Distinguish return codes returned from the target API and those returned by Application Gateway (is this 5xx mine or not)
  • Consider adding possibility to define multiple log levels.
  • Consider using tools for logging in a structured way (kyma/common)
  • Consider ability to change log level without component restart (there is a solution in function controller)
  • Consider using tracing to observe how the request is modified

Reasons

Better logs will make it easier to find issues faster.

@Disper Disper added the area/application-connector Issues or PRs related to application connectivity label Apr 7, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akgalwas akgalwas reopened this Jun 21, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@akgalwas akgalwas reopened this Jun 29, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Jul 6, 2023

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

kyma-bot commented Jul 6, 2023

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot closed this as completed Jul 6, 2023
@Disper Disper removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 10, 2023
@Disper Disper reopened this Jul 10, 2023
@Disper
Copy link
Member Author

Disper commented Jul 11, 2023

Adding a suggestion received from @ebensom on an internal tool that we can't cross-link here:

the "proxy" logs to proper access logs, which at least contain
- request URL (scheme, host, port, path)
- response code
- response size
- response duration in ms (optional)

@akgalwas
Copy link
Contributor

In the first step we must ensure that:

  • it is possible to distinguish whether the error code was returned by the target API or the Application Gateway (please ind this comment)
  • for 5xx errors Application Gateway should return 502 so that SLA calculation for Application Gateway doesn't include errors returned by the target API

@VOID404 VOID404 self-assigned this Jul 31, 2023
@VOID404 VOID404 linked a pull request Aug 1, 2023 that will close this issue
@VOID404 VOID404 linked a pull request Aug 22, 2023 that will close this issue
@Disper Disper assigned Disper and mvshao and unassigned Disper Aug 23, 2023
@akgalwas akgalwas removed their assignment Aug 28, 2023
@Disper Disper added this to the 2.19 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants