Configure helm-broker repository baseURL to github pages, remove embedded reposerver #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrmiskiewicz
requested review from
aszecowka,
mszostok,
PK85 and
polskikiel
as code owners
piotrmiskiewicz
added
area/service-management
8 tasks
piotrmiskiewicz
requested review from
crabtree,
jakkab,
kazydek,
klaudiagrz,
mwieczorek,
piotrmsc,
strekm,
Tomasz-Smelcerz-SAP,
tomekpapiernik,
a-thaler,
clebs,
lilitgh and
suleymanakbas91
as code owners
mszostok
suggested changes
Oct 4, 2018
| @@ -1,7 +0,0 @@ | |||
| # Reposerver | |||
There was a problem hiding this comment.
Please delete also:
helm-broker/deploy/reposerver/Dockerfile- entry /reposerver from .gitignore file
| @@ -17,5 +17,4 @@ Resources currently include, but are not limited to, the following: | |||
| - Elements which are essential for the installation of `core` components in Kyma, such as certificates, users, and permissions | |||
| - The `core` components required to run the Kyma | |||
| - Examples of the use of specific components | |||
| - The repository of bundles that are exposed in the Service Catalog as Service Classes through the Helm Broker | |||
There was a problem hiding this comment.
please also adjust the documentation in this file:
- docs/service-brokers/docs/004-overview-helm-broker.md
- docs/service-brokers/docs/011-configuration-helm-broker.md
- docs/service-brokers/docs/021-architecture-helm-broker.md
piotrmiskiewicz
changed the title
piotrmiskiewicz
force-pushed
the
set-broker-repo-to-github-pages
branch
from
1238dad to
b5c355f
Compare
klaudiagrz
reviewed
Oct 5, 2018
| @@ -3,6 +3,6 @@ title: Helm Broker | |||
| type: Overview | |||
| --- | |||
|
|
|||
| The Helm Broker is an implementation of a service broker which runs in the Kyma cluster and deploys Kubernetes native resources using [Helm](https://github.com/kubernetes/helm) and Kyma bundles. A bundle is an abstraction layer over a Helm chart which allows you to represent it as a ClusterServiceClass in the Service Catalog. For example, a bundle can provide plan definitions or binding details. The Helm Broker fetches bundle definitions from an HTTP server. By default, the Helm Broker contains an embedded HTTP server which serves bundles from the Kyma bundles directory. | |||
| The Helm Broker is an implementation of a service broker which runs in the Kyma cluster and deploys Kubernetes native resources using [Helm](https://github.com/kubernetes/helm) and Kyma bundles. A bundle is an abstraction layer over a Helm chart which allows you to represent it as a ClusterServiceClass in the Service Catalog. For example, a bundle can provide plan definitions or binding details. The Helm Broker fetches bundle definitions from an HTTP server. By default, the Helm Broker fetches bundles from the [stable kyma-bundles repository](https://kyma-incubator.github.io/kyma-bundles/stable/). | |||
There was a problem hiding this comment.
kyma-bundles- Fix a broken link
| config: | ||
| repository: | ||
| baseURL: "http://custom.bundles-repository" | ||
| ``` | ||
|
|
||
| 3. Install Kyma on Minikube. See the **Local Kyma installation** document to learn how. | ||
| 2. Install Kyma on Minikube. See the **Local Kyma installation** document to learn how. |
There was a problem hiding this comment.
3. -> please fix the numeration
piotrmiskiewicz
force-pushed
the
set-broker-repo-to-github-pages
branch
from
b5c355f to
2fb4cb2
Compare
mszostok
approved these changes
Oct 5, 2018
klaudiagrz
approved these changes
Oct 5, 2018
piotrmiskiewicz
force-pushed
the
set-broker-repo-to-github-pages
branch
3 times, most recently
from
917da2b to
6b538d2
Compare
suleymanakbas91
approved these changes
Oct 5, 2018
PK85
requested changes
Oct 7, 2018
|
|
||
| config: | ||
| repository: | ||
| baseURL: "http://core-helm-broker-reposerver" | ||
| baseURL: "https://kyma-project.github.io/kyma-bundles/stable/" |
There was a problem hiding this comment.
piotrmiskiewicz
force-pushed
the
set-broker-repo-to-github-pages
branch
from
6b538d2 to
f7360ba
Compare
piotrmiskiewicz
force-pushed
the
set-broker-repo-to-github-pages
branch
from
f7360ba to
764563d
Compare
PK85
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Related: #592
Related: #1181