Add namespaced ui-api-acceptance tests

[magicmatatjahu]

Description

Changes proposed in this pull request:

• Add namespaced ui-api-acceptance tests for ClusterServiceBroker, ServiceBroker, ClusterServiceClass, ServiceClass,
• Add serviceBrokers to ClusterRole

Related issue(s)
See also #952

[pkosiec]

Please use everywhere full names for resources, e.g.: clusterServiceClass, serviceClass,
the same thing with brokers

[pkosiec]

I'd use full name: clusterServiceClass & serviceClass everywhere

[magicmatatjahu]

Done

[pkosiec]

I think this fragment can be extracted:

	for _, v := range arr {
				if v.Type == "Ready" {
					return v.Status == "True", nil
				}
			}
			log.Printf("%s %s still not ready. Waiting...\n", typeOfBroker, brokerName)

Because in brokers there is the same CommonServiceBrokerStatus type.

[magicmatatjahu]

Done. I changed this function to:

func checkStatusOfBroker(conditions []v1beta1.ServiceBrokerCondition) bool {
	for _, v := range conditions {
		if v.Type == "Ready" {
			return v.Status == "True"
		}
	}
	return false
}

func waitForBroker(brokerName, typeOfBroker string, svcatCli *clientset.Clientset) error {
	return waiter.WaitAtMost(func() (bool, error) {
		var conditions []v1beta1.ServiceBrokerCondition

		if typeOfBroker == tester.ClusterServiceBroker {
			broker, err := svcatCli.ServicecatalogV1beta1().ClusterServiceBrokers().Get(brokerName, metav1.GetOptions{})

			if err != nil || broker == nil {
				return false, err
			}

			conditions = broker.Status.Conditions
		} else {
			broker, err := svcatCli.ServicecatalogV1beta1().ServiceBrokers(tester.DefaultNamespace).Get(brokerName, metav1.GetOptions{})

			if err != nil || broker == nil {
				return false, err
			}

			conditions = broker.Status.Conditions
		}

		if checkStatusOfBroker(conditions) {
			return true, nil
		}

		log.Printf("%s %s still not ready. Waiting...\n", typeOfBroker, brokerName)
		return false, nil
	}, brokerReadyTimeout)
}

[pkosiec]

LGTM

[pkosiec]

Please edit ClusterRole to include servicebroker privilege.

2018/10/08 07:40:44 servicebrokers.servicecatalog.k8s.io "ups-broker" is forbidden: User "system:serviceaccount:kyma-system:test-core-core-ui-api-acceptance" cannot get servicebrokers.servicecatalog.k8s.io in the namespace "ui-api-acceptance"

[hudymi]

LGTM

[hudymi]

Fix indents.