-
Notifications
You must be signed in to change notification settings - Fork 403
Prepare Application Connector for Modularisation #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AC chart is installed by running:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
minor changes:
- add the annotation to remote-environment.crd.yaml file
annotations: "helm.sh/hook": crd-install
- remove unecessary
requirements.yaml
file - and move rebNamespace under the remoteEnviroment property:
remoteEnvironment: disabled: "false" brokerNamespace: kyma-integration linkingTimeout: 4m unlinkingTimeout: 4m
Hi @janmedrek, one question, why global.isLocalEnv is set to false? I have been working in Modularize OKLog Installation and the why I was able to install logging chart was with |
@venturasr Hey, this parameter needs to be provided in order to install our helm charts, whether it is true or not depends solely on type of installation (tests config, some of them are not ran in local environment). |
Description
Changes proposed in this pull request:
Related issue(s)
#542