Skip to content

Prepare Application Connector for Modularisation #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 19, 2018
Merged

Prepare Application Connector for Modularisation #1153

merged 16 commits into from
Oct 19, 2018

Conversation

janmedrek
Copy link
Contributor

@janmedrek janmedrek commented Oct 5, 2018

Description

Changes proposed in this pull request:

  • AC components moved out of the core to the new Application Connector chart
  • REB moved to the new chart
  • NGINX moved to the new chart

Related issue(s)
#542

@janmedrek janmedrek added WIP area/application-connector Issues or PRs related to application connectivity labels Oct 5, 2018
@janmedrek janmedrek added this to the Sprint_Framefrog_2 milestone Oct 5, 2018
@janmedrek janmedrek changed the title Refactor ac chart Prepare Application Connector for Modularisation Oct 5, 2018
@janmedrek
Copy link
Contributor Author

AC chart is installed by running:

helm install --name ac --set global.isLocalEnv=false --set global.domainName=kyma.local .

@janmedrek janmedrek requested a review from aerfio as a code owner October 18, 2018 11:19
@janmedrek janmedrek removed the WIP label Oct 18, 2018
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

minor changes:

  • add the annotation to remote-environment.crd.yaml file
    annotations:
      "helm.sh/hook": crd-install
    
  • remove unecessary requirements.yaml file
  • and move rebNamespace under the remoteEnviroment property:
        remoteEnvironment:
          disabled: "false"
    
          brokerNamespace: kyma-integration
          linkingTimeout: 4m
          unlinkingTimeout: 4m
    

@venturasr
Copy link
Contributor

AC chart is installed by running:

helm install --name ac --set global.isLocalEnv=false --set global.domainName=kyma.local .

Hi @janmedrek, one question, why global.isLocalEnv is set to false? I have been working in Modularize OKLog Installation and the why I was able to install logging chart was with --set global.isLocalEnv=false as it will be installed locally. Please let me know if I am wrong.

@janmedrek
Copy link
Contributor Author

janmedrek commented Oct 18, 2018

@venturasr Hey, this parameter needs to be provided in order to install our helm charts, whether it is true or not depends solely on type of installation (tests config, some of them are not ran in local environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants