Skip to content

Change the policy for chart directory in bundle #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

Change the policy for chart directory in bundle #1210

merged 1 commit into from
Oct 11, 2018

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Oct 10, 2018 •
edited
Loading

Description

Changes proposed in this pull request:

  • Change the policy for chart directory in a bundle:
    • chart directory MUST contain only one folder, if more folders are discovered then the proper error is logged with directories names that causing problems
    • all files in chart directory are ignored but logged for transparency of loading process. Thanks to that we have the similar policy in the whole bundle folder, e.g in plans we also taking into account only the directories and ignoring files.

Related issue(s)

@mszostok mszostok added kind/feature Categorizes issue or PR as related to a new feature. area/service-management Issues or PRs related to service management labels Oct 10, 2018
@PK85 PK85 mentioned this pull request Oct 10, 2018
Closed
8 tasks
aszecowka
aszecowka approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@aszecowka aszecowka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mszostok mszostok merged commit 2e99513 into kyma-project:master Oct 11, 2018
@mszostok mszostok deleted the helm-broker branch December 3, 2018 08:25
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Create new jobs for cluster-user tests (kyma-project#1210)
920398c 
* Create jobs for cluster-user tests

* Fix release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszecowka aszecowka aszecowka approved these changes

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

@PK85 PK85 Awaiting requested review from PK85

@polskikiel polskikiel Awaiting requested review from polskikiel

Assignees
No one assigned
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @aszecowka