Console enable http with redirect to https #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
added
kind/feature
maxmarkus
requested review from
a-thaler,
derberg,
lszymik,
pbochynski and
PK85
as code owners
derberg
approved these changes
Oct 13, 2018
piotrmsc
suggested changes
Oct 15, 2018
| httpsRedirect: true # automatic 301 redirect from http to https | ||
| hosts: | ||
| - "console.{{.Values.global.domainName}}" |
There was a problem hiding this comment.
Instead of listing hosts here please provide a wildcard like we have above.
If we have console and grafana we could have as well dex, jaeger, ui-api etc. so it's better have the same config like with https
piotrmsc
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added port 80 to gateway for console with https redirect.