Adding a possibility to skip SSL certificate verification in Connector Service acceptance tests #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 28, 2018 12:10
…lf-signed certificate
…lf-signed certificate
lszymik
added
kind/feature
lszymik
requested review from
akgalwas,
bszwarc,
franpog859,
janmedrek,
kazydek,
klaudiagrz,
Maladie,
Szymongib and
tomekpapiernik
as code owners
Szymongib
reviewed
Oct 12, 2018
| } | ||
|
|
||
| func NewConnectorClient(remoteEnv, internalAPIUrl, externalAPIUrl string) ConnectorClient { | ||
| func NewConnectorClient(remoteEnv, internalAPIUrl, externalAPIUrl string, client *http.Client) ConnectorClient { |
There was a problem hiding this comment.
I would suggest passing only boolean and instantiating the client in NewConnectorClient method:
func NewConnectorClient(remoteEnv, internalAPIUrl string, skipVerify bool) ConnectorClient {
client := NewHttpClient(skipVerify)
return connectorClient{
remoteEnv: remoteEnv,
internalAPIUrl: internalAPIUrl,
httpClient: client,
}
}
added 2 commits
October 12, 2018 11:50
…lf-signed certificate
…lf-signed certificate
Szymongib
approved these changes
Oct 15, 2018
kazydek
suggested changes
Oct 15, 2018
| @@ -2,53 +2,36 @@ | |||
|
|
|||
| ## Overview | |||
|
|
|||
| This project contains the acceptance tests for Connector Service. | |||
| The tests are written in Go. Run them as standard Go tests. | |||
| This project contains the acceptance tests for Kyma Connector Service. | |||
|
|
||
| ## Prerequisites | ||
|
|
||
| The Connector Service Acceptance Tests requires Go 1.8 or higher. |
|
|
||
| The Connector Service Acceptance Tests requires Go 1.8 or higher. | ||
|
|
||
| ## Build |
|
|
||
| 1. `git clone [email protected]:kyma-project/kyma.git` | ||
| 2. `cd /tests/connector-service-tests` | ||
| 3. `CGO_ENABLED=0 go build ./test/apitests/connector_test.go` | ||
|
|
||
| ## Usage |
There was a problem hiding this comment.
Pls add an introductory sentence, we try to avoid stacked headings - Read which environment parameters to use and how to run tests.
| ok github.com/kyma-project/gateway-tests/test 0.003s | ||
| ``` | ||
| ### Environment parameters | ||
|
|
There was a problem hiding this comment.
Are all of them obligatory? Perhaps it would be better to add a table similar to the one here?
Either way, pls add some sort of description above the list, e.g. Use these environment variables to configure the application:
| * **GATEWAY_URL** - The URL of Remote Environment Gateway API | ||
| * **SKIP_SSL_VERIFY** - A flag for skipping SSL certificate validation | ||
|
|
||
| ### Running |
There was a problem hiding this comment.
### Run the tests (we try to avoid gerund - ing - forms)
| * **INTERNAL_API_URL** - The URL of Connector Service internal API | ||
| * **EXTERNAL_API_URL** - The URL of Connector Service external API | ||
| * **GATEWAY_URL** - The URL of Remote Environment Gateway API | ||
| * **SKIP_SSL_VERIFY** - A flag for skipping SSL certificate validation |
There was a problem hiding this comment.
* **INTERNAL_API_URL** is the URL of the Connector Service internal API.
* **EXTERNAL_API_URL** is the URL of the Connector Service external API.
* **GATEWAY_URL** is the URL of the Remote Environment Gateway API.
* **SKIP_SSL_VERIFY** is a flag for skipping the SSL certificate validation.
| ### Running | ||
|
|
||
| 1. Provide all required environment parameters | ||
| 2. Execute tests |
|
|
||
| ### Running | ||
|
|
||
| 1. Provide all required environment parameters |
There was a problem hiding this comment.
1. Provide all required environment parameters. - Could you provide an example of what you mean in this step?
| * **SKIP_SSL_VERIFY** - A flag for skipping SSL certificate validation | ||
|
|
||
| ### Running | ||
|
|
There was a problem hiding this comment.
Pls add some sort of introduction: Follow these steps to run acceptance tests: or sth, we should introduce bullet points and steps somehow.
…lf-signed certificate
kazydek
approved these changes
Oct 15, 2018
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
* Add test * Review fixes * Change regexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Fixes #1077