Stability checker - fix path for testing script. #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszecowka
added
kind/bug
aszecowka
requested review from
bszwarc,
jasiu001,
kazydek,
klaudiagrz,
mszostok,
piotrmiskiewicz,
PK85,
polskikiel and
tomekpapiernik
as code owners
tomekpapiernik
approved these changes
Oct 15, 2018
mszostok
reviewed
Oct 15, 2018
| @@ -14,7 +14,7 @@ image: | |||
| storage: | |||
| claimName: "stability-test-scripts-pvc" | |||
|
|
|||
| pathToTestingScript: "/data/input/testing-kyma.sh" | |||
| pathToTestingScript: "/data/input/testing.sh" | |||
There was a problem hiding this comment.
IMO modification this value here for fixing purpose is more like a side effect. This should be changed in /install-stability-checker.sh script where we are mounting given script. There we should define the contract. What's more this solution is temporary and error prone
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
* Add compass schema-migrator component build job * Use older image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.