Skip to content

Fix creating and updating hostnames in Api controller #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2018

Conversation

kubadz
Copy link
Contributor

@kubadz kubadz commented Oct 29, 2018

Description

Changes proposed in this pull request:

  • update types: change UpdateFailure status to HostnameOccupied
  • fix error handling in the controller
  • fix VirtualService Update logic
  • adjust unit tests to changes in VirtualService update handling

Related issue(s)

See also #1147

@kubadz kubadz self-assigned this Oct 29, 2018
@kubadz kubadz requested a review from piotrmsc October 29, 2018 06:44
@kubadz kubadz requested a review from sjanota as a code owner October 29, 2018 06:44
@kubadz kubadz merged commit a20eb49 into kyma-project:master Oct 29, 2018
@kubadz kubadz deleted the api-controller-hostname-fix branch October 29, 2018 09:38
@kubadz kubadz added area/service-mesh Issues or PRs related to service-mesh kind/bug Categorizes issue or PR as related to a bug. labels Oct 30, 2018
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Issues or PRs related to service-mesh kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants