Skip to content

runtime overrides-2 #17651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

runtime overrides-2 #17651

wants to merge 22 commits into from

Conversation

iamps5
Copy link
Contributor

@iamps5 iamps5 commented Jun 12, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

With the Kyma modularization the overrides to Kyma modules on SKRs supplied by management-plane-config shall be kept absolutely minimum. So, We are moving all the latest overrides for eventing, ory & serverless here

Related issue(s)

@iamps5 iamps5 requested review from a team as code owners June 12, 2023 18:26
@iamps5 iamps5 requested a review from mfaizanse June 12, 2023 18:26
@netlify
Copy link

netlify bot commented Jun 12, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit eec52a3
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64d244542490140008af12da
😎 Deploy Preview https://deploy-preview-17651--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

Hi @iamps5. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2023
@iamps5
Copy link
Contributor Author

iamps5 commented Jun 12, 2023

@ebensom can you please take a look?

ebensom
ebensom reviewed Jun 13, 2023
View reviewed changes
friedrichwilken
friedrichwilken previously approved these changes Jun 15, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 15, 2023
@mfaizanse
Copy link
Member

/test pre-main-kyma-gardener-gcp-eventing

@mfaizanse mfaizanse removed their assignment Jul 31, 2023
@mfaizanse
Copy link
Member

/retest

3 similar comments
@lumi017
Copy link
Contributor

lumi017 commented Aug 2, 2023

/retest

@lumi017
Copy link
Contributor

lumi017 commented Aug 3, 2023

/retest

@lumi017
Copy link
Contributor

lumi017 commented Aug 4, 2023

/retest

@iamps5 iamps5 dismissed stale reviews from friedrichwilken, triffer, and kwiatekus via eec52a3 August 8, 2023 13:34
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2023
@mfaizanse mfaizanse mentioned this pull request Aug 8, 2023
Closed
@mfaizanse
Copy link
Member

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 9, 2023

@iamps5: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
mfaizanse_test_of_prowjob_pre-main-kyma-gardener-gcp-eventing-u eec52a3 link false /test pre-main-kyma-gardener-gcp-eventing-upgrade
pre-main-kyma-gardener-gcp-eventing-upgrade eec52a3 link true /test pre-main-kyma-gardener-gcp-eventing-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@friedrichwilken friedrichwilken removed their assignment Aug 9, 2023
@marcobebway
Copy link
Contributor

Please don't change the Eventing overrides. We already reduced the Eventing requested resources as part of this ticket

marcobebway
marcobebway suggested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@marcobebway marcobebway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the Eventing overrides. We already reduced the Eventing requested resources as part of this ticket

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 6, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 5, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot kyma-bot closed this Nov 12, 2023
@kyma-bot
Copy link
Contributor

@kyma-bot: Closed this PR.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebensom ebensom ebensom left review comments

@marcobebway marcobebway marcobebway requested changes

@mfaizanse mfaizanse mfaizanse approved these changes

@kwiatekus kwiatekus kwiatekus left review comments

@triffer triffer triffer left review comments

@friedrichwilken friedrichwilken friedrichwilken left review comments

Assignees

@kwiatekus kwiatekus

@mfaizanse mfaizanse

@triffer triffer

@marcobebway marcobebway

@iamps5 iamps5

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@iamps5 @kyma-bot @friedrichwilken @mfaizanse @lumi017 @marcobebway @kwiatekus @ebensom @triffer