Skip to content

Remove relative link from CRD description #17770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Jun 29, 2023

Description

The CRD description for the unsupportedMode status field contained a relative link to the docs. Since this description has also other purposes, this PR makes it an absolute link that work everywhere.

We may change the link from main to latest once the new docs structure is released.

Changes proposed in this pull request:

  • Remove relative link from CRD description
  • Fix table-gen commands in Makefile

Related issue(s)

See #17454

@chrkl chrkl requested review from k15r and a team as code owners June 29, 2023 10:45
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit b3ac535
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/649d60b36d3c4a0008f87605
😎 Deploy Preview https://deploy-preview-17770--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 29, 2023
@kyma-bot kyma-bot merged commit e24f237 into kyma-project:main Jul 3, 2023
@chrkl chrkl deleted the fix-unsupported-link branch July 3, 2023 12:13
@a-thaler a-thaler added the area/telemetry Issues or PRs related to the telemetry module label Jul 7, 2023
@a-thaler a-thaler added this to the 2.17 milestone Jul 7, 2023
@a-thaler a-thaler added the area/documentation Issues or PRs related to documentation label Jul 7, 2023
pPrecel pushed a commit to pPrecel/kyma that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/telemetry Issues or PRs related to the telemetry module lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants