Skip to content

Bump kiwigrid k8s-sidecar to 1.24.6 version #17812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

a-thaler
Copy link
Contributor

@a-thaler a-thaler commented Jul 7, 2023

Description
We did not update the sidecar version for a long time as we observed increased resource consumption.
I tried it once more and using the additional flag IGNORE_ALREADY_PROCESSED the consumption is very similar as before. The big advantage is that logs are now in JSON and the info logs are reduced to a minimum. As the resources are not getting processed constantly anymore but only on changes, the amount of logs is reduced heavily.

Changes proposed in this pull request:

  • update to latest version 1.24.6
  • add new flag which works from k8s 1.19 on, to process only changed resources

Related issue(s)

kyma-project/third-party-images#364

@a-thaler a-thaler added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Jul 7, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 14138fd
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64b154c6eac2b50007dffcd8
😎 Deploy Preview https://deploy-preview-17812--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

kyma-bot commented Jul 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2023
@skhalash skhalash self-assigned this Jul 10, 2023
@skhalash
Copy link
Contributor

Let's convert it to a regular PR?

@kyma-bot
Copy link
Contributor

@a-thaler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance f2071e1 link true /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skhalash skhalash changed the title update kiwigrid k8s-sidecar to 1.24.6 version Bump kiwigrid k8s-sidecar to 1.24.6 version Jul 14, 2023
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2023
@a-thaler a-thaler marked this pull request as ready for review July 14, 2023 13:50
@a-thaler a-thaler requested a review from a team as a code owner July 14, 2023 13:50
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2023
@a-thaler
Copy link
Contributor Author

I updated to the final image, ready for review

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 14, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 14, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 14, 2023
@kyma-bot kyma-bot merged commit 1d0b38d into kyma-project:main Jul 14, 2023
@skhalash skhalash deleted the kiwi branch July 14, 2023 17:42
@a-thaler a-thaler added this to the 2.17 milestone Jul 17, 2023
pPrecel pushed a commit to pPrecel/kyma that referenced this pull request Jul 17, 2023
* update kiwigrid k8s-sidecar to 1.24.6 version

* use of final image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants