Skip to content

expose health status as metric #17839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2023
Merged

expose health status as metric #17839

merged 6 commits into from
Jul 21, 2023

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Jul 17, 2023

Description

Changes proposed in this pull request:

  • expose health status as metric. This is similar to up, but easier to modify in the future without changing the alert implementation

Related issue(s)

@k15r k15r requested a review from a team as a code owner July 17, 2023 12:37
@k15r k15r requested a review from friedrichwilken July 17, 2023 12:37
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 5bb252a
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64b8fbd8e4db2700088c1bf1
😎 Deploy Preview https://deploy-preview-17839--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2023
@k15r k15r requested a review from a team as a code owner July 17, 2023 13:39
@k15r k15r added the area/eventing Issues or PRs related to eventing label Jul 17, 2023
NHingerl
NHingerl previously approved these changes Jul 17, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 17, 2023
@friedrichwilken
Copy link
Contributor

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@k15r k15r dismissed stale reviews from friedrichwilken and NHingerl via 5bb252a July 20, 2023 09:18
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 20, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 20, 2023
@mfaizanse
Copy link
Member

/retest

@kyma-bot
Copy link
Contributor

@k15r: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance 5bb252a link false /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 270f870 into kyma-project:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add new metric that mirrors the state of the health check in EPP
5 participants