Adapt EC for eventing manager #17852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muralov
added
the
do-not-merge/hold
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kyma-bot
added
the
size/M
* Make NATS_URL not required * Make EC owner reference set with flag
muralov
force-pushed
the
adapt-for-eventing-manager
branch
2 times, most recently
from
66068c8 to
8529ebc
Compare
muralov
force-pushed
the
adapt-for-eventing-manager
branch
from
8529ebc to
6103b96
Compare
4 tasks
friedrichwilken
requested changes
Jul 19, 2023
components/eventing-controller/controllers/backend/reconciler.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/controllers/backend/reconciler.go
Outdated
Show resolved
Hide resolved
friedrichwilken
approved these changes
Jul 19, 2023
muralov
removed
the
do-not-merge/hold
|
@contributor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt Eventing Controller to be able to be used by Eventing Manager
Changes proposed in this pull request:
Related issue(s)
issue