Contract test between api-gateway and serverless #17894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/L
|
/test all |
kyma-bot
removed
the
do-not-merge/work-in-progress
MichalKalke
added
area/tests
MichalKalke
changed the title
dbadura
reviewed
Jul 27, 2023
| return errors.Wrap(err, "while trying to get service") | ||
| } | ||
|
|
||
| pods, err := d.client.Pods(d.namespace).List(context.Background(), metav1.ListOptions{LabelSelector: resourceLabel}) |
There was a problem hiding this comment.
We can implement such selector:
kubectl get pod -n test-simple-tracing-11h22m49s -l serverless.kyma-project.io/function-name=nodejs16,serverless.kyma-project.io/resource=deployment
|
/test all |
dbadura
reviewed
Jul 31, 2023
|
|
||
| for _, label := range requiredLabels { | ||
| if _, exists := labels[label]; !exists { | ||
| return errors.New(fmt.Sprintf("Label %s is missing", label)) |
There was a problem hiding this comment.
We can gather all errors by using https://pkg.go.dev/errors#Join
| if val == v { | ||
| delete(service.Spec.Selector, k) | ||
| } else { | ||
| return errors.Errorf("Expected %s but got %s", v, val) |
There was a problem hiding this comment.
We can gather all errors by using https://pkg.go.dev/errors#Join
|
|
||
| err = checkIfRequiredLabelsExists(svc.Spec.Selector, true) | ||
| if err != nil { | ||
| return errors.Wrap(err, " in service") |
There was a problem hiding this comment.
I think you should write it in such way: errors.Wrap(err, "while checking the service labels
|
/test all |
|
/retest |
dbadura
approved these changes
Aug 1, 2023
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kubernetes resources produced by serverless must satisfy API-gateway label selectors so that when istio and api-gateway are installed, user may add a sidecar to the function pod and expose its API.
Changes proposed in this pull request:
PodandServiceare the sameRelated issue(s)
#17506