Skip to content

Handle 5XX statuses in gateway #18007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Aug 21, 2023

List of Changes:

  1. All 5XX response codes from the target system will be changed to 502 status code.
  2. The original response code from the target system is now included in the response headers Target-System-Status.

Rationale:

This change aims to provide clearer error reporting. With the previous setup, the variety of 5XX error codes could lead to ambiguity regarding the error source. By standardizing all 5XX errors to a 502 response, it is clear that the error originates from the target system, not the proxy. The original status code is still available in the Target-System-Status header for those who need to investigate further. This approach simplifies error handling, aids in debugging, and improves the clarity of our system's response behavior.

Related issue(s)

@VOID404 VOID404 requested a review from a team as a code owner August 21, 2023 06:49
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit dc2ccf9
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64e308e89267c80008edc68e
😎 Deploy Preview https://deploy-preview-18007--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 21, 2023
@kyma-bot kyma-bot merged commit f9ec5ec into kyma-project:main Aug 21, 2023
@VOID404 VOID404 mentioned this pull request Aug 21, 2023
@Disper Disper added this to the 2.18 milestone Aug 24, 2023
@Disper Disper added the area/application-connector Issues or PRs related to application connectivity label Aug 24, 2023
@VOID404 VOID404 mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants