Skip to content

Make eventing-controller to not crash when nats is not present #18175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

mfaizanse
Copy link
Member

Description

Changes proposed in this pull request:

  • Make eventing-controller to not crash when nats is not present

Related issue(s)

@mfaizanse mfaizanse requested a review from a team as a code owner September 15, 2023 11:51
@netlify
Copy link

netlify bot commented Sep 15, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 27c3516

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 27c3516
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65044888b47ee50008c9514c
😎 Deploy Preview https://deploy-preview-18175--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2023
@mfaizanse
Copy link
Member Author

kyma deploy --source=PR-18175 --profile=production --value eventing.global.jetstream.enabled=false

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 15, 2023
@kyma-bot kyma-bot merged commit 59ba575 into kyma-project:main Sep 15, 2023
@mfaizanse mfaizanse deleted the bg-22 branch September 15, 2023 13:26
mfaizanse added a commit to mfaizanse/kyma that referenced this pull request Sep 15, 2023
…project#18175)

* Make eventing-controller to not crash when nats is not present
mfaizanse added a commit that referenced this pull request Sep 15, 2023
* Make eventing-controller to not crash when nats is not present (#18175)

* Make eventing-controller to not crash when nats is not present

* undo image bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants