Make is-installed script not exit on error #2087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do not immediately exit with code 1 on Error status
kubadz
requested review from
a-thaler,
adamwalach,
aszecowka,
bszwarc,
crabtree,
derberg,
jakkab,
jasiu001,
kazydek,
klaudiagrz,
lszymik,
hudymi,
mszostok,
mwieczorek,
pbochynski,
piotrmiskiewicz,
piotrmsc,
PK85,
polskikiel,
strekm,
suleymanakbas91,
Tomasz-Smelcerz-SAP and
tomekpapiernik
as code owners
kubadz
added
area/installation
sjanota
approved these changes
Dec 20, 2018
Tomasz-Smelcerz-SAP
approved these changes
Dec 20, 2018
strekm
approved these changes
Dec 21, 2018
pbochynski
approved these changes
Jan 3, 2019
tomekpapiernik
suggested changes
Jan 3, 2019
…nguage review Co-Authored-By: kubadz <[email protected]>
tomekpapiernik
approved these changes
Jan 3, 2019
|
/retest |
aszecowka
pushed a commit
to aszecowka/kyma
that referenced
this pull request
Jan 10, 2019
* add timeout option to is-installed script * add info about the script * do not immediately exit with code 1 on Error status * add information about is-installed script to docs * add default timeout to is-installed script on CI * do not use echo and subshell to print output from kubectl * move information about timeout below the logs from installer * update codeowners
aszecowka
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Make is-installed script not exit on error (#2087) * add timeout option to is-installed script * add info about the script * do not immediately exit with code 1 on Error status * add information about is-installed script to docs * add default timeout to is-installed script on CI * do not use echo and subshell to print output from kubectl * move information about timeout below the logs from installer * update codeowners * Use bundles 0.2.0 - added testing bundles. (#2178) * Bump Instances Image * Allow to pass ingressgateway service name (#2186) * Luigified Console (#1991) Luigified Console * Split "servicecatalog" module in UI API Layer Acceptance tests (#2168) * Add shared types, fixtures and wait helpers * Do not skip tests when SCI is not enabled * Split servicecatalog domain for UI API acceptance tests * Move service catalog installation to shared package * Increase timeout for BackendModule test * Make separate namespaces for SC and SCA tests * Rename SkipMainIfShould and SkipTestIfShould methods * Split "servicecatalog" domain in UI API Layer (#2174) * Move files to servicecatalogaddons domain * Adjust changes to servicecatalogaddons * Finish splitting SC domain to SC and SCA * Format code * Make cross-domain dependencies nullable * Create separate resolver for application field in environments * Improve the overall SC documentation (#2177) * Fix the links in the SC documentation (#2198) * Stabilize ui tests for variable network conditions (#2201) * stabilize ui tests for variable network conditions * stabilize ui tests for variable network conditions * Fix GKE installation with dynamic IPs (#2187) * Fix dynamic IPs * Set knative domain * Set ingress service name in xip-patch * Fix passing external ip to istio * Fix again * Revert "Fix again" This reverts commit e41f7f1. * And one more fix * Add badges to readme to point to slack and twitter (#2224) * incorporate default clusterrolebinding into minikube.sh (#2204) * Support for minikube restart (#2156) * Support minikube restart * TW updates * TW review 2 * Bump lambda UI Image to latest (#2219) * Remove function for calling Bash scripts from the Installer component (#2226) * Skip Application charts installation in acceptance tests if not needed (#2154) * Rename dummyRe to dummyApp * Skip app chart installation in connector-service and application-registry * Add random postfix for connector test pods names * Dep ensure connector-tests * Dep ensure with dep 0-4-1 * Add random postfix to app registry test apps * Go fmt changed files * Add skip chart installation for apps in acceptance tests * Add skip all charts installation for apps in acceptance tests * Rename RE to Application * Add docs how to install Knative from release (#2218) * Add docs how to install Knative from release * Apply suggestions from code review Co-Authored-By: sjanota <[email protected]> * Update 038-inst-knative.md * link fix * Update version of components to 0.6.0-rc2 * Add finalizers to Applications (#2199) * Update xip installation documentation (#2205) * Disable cache in ui tests (#2228) disable cache in ui tests and extend default navigation timeout * Introduce UI API Layer documentation (#2229) * Add BackendModule CR description * Describe UI API Layer * Improve language in UI API Layer docs * Adjust labels in console UI (#2207) * Adjust labels in console UI * Bump content-ui image (#2234) * Bump image of Application Operator (#2232) * Fix console-basic-test (#2239) * Fix console-basic-test * Fix image name of Application Operator tests (#2241) * Bump console core image (#2242) * Add cluster name info to the stability checker summary (#2235) * Add cluster name info to the stability checker summary * Update tools/stability-checker/README.md * Bump Instances image * Update grafana and lambda ui documentation (#2200) * Update grafana and lambda ui documentation * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/core/charts/kubeless/charts/lambdas-ui/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Update README.md * Update resources/monitoring/charts/grafana/README.md Co-Authored-By: venturasr <[email protected]> * Updated base images (#2247) * Bump stability-checker version (#2249) * Fix EventActivation ark backups (#2254) * Update image version for all console components (#2252)
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the logic responsible for immediately returning an error code from the is-installed script when the Status in Installation CR becomes
Error. By default, the script will wait forever until the installation will be successful, but there is also an option added allowing to set the timeout after which the script will return an error code. The script additionally fetches logs from the installer if the timeout occurs while theErrorstatus is set on Installation CR.Changes proposed in this pull request:
ErrorRelated issue(s)
Reasons of introducing those changes are described in #1610