Remote Environment Controller acceptance tests #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymongib
added
kind/feature
Szymongib
requested review from
kazydek,
klaudiagrz,
lilitgh,
pbochynski,
PK85,
suleymanakbas91 and
tomekpapiernik
as code owners
klaudiagrz
suggested changes
Sep 18, 2018
|
|
||
| ## Usage | ||
|
|
||
| This section provides information on building and versioning of the Docker image, as well as configuring the Kyma. |
There was a problem hiding this comment.
This section provides information on building and versioning of the Docker image, as well as configuring the Kyma.
|
|
||
| This section provides information on building and versioning of the Docker image, as well as configuring the Kyma. | ||
|
|
||
| ### Configuring the Kyma |
|
|
klaudiagrz
approved these changes
Sep 19, 2018
Szymongib
force-pushed
the
re-controller-tests
branch
from
b20d802 to
04adee1
Compare
akgalwas
reviewed
Sep 19, 2018
| return deployment, err | ||
| } | ||
|
|
||
| func shouldRetry(err error, shouldFail bool) bool { |
There was a problem hiding this comment.
This function is not easy to read since it covers two scenarios : checks for adding and removal.Please, get rid of it.
akgalwas
reviewed
Sep 19, 2018
|
|
||
| helmClient := testkit.NewHelmClient(config.TillerHost, retryCount, retryWaitTime*time.Second) | ||
| testReName := "test-create-re" | ||
| k8sResourcesChecker := testkit.NewK8sResourceChecker(testReName, k8sResourcesClient, retryCount, retryWaitTime*time.Second) |
There was a problem hiding this comment.
Please define retryWaitTimeSeconds with the following value: retryWaitTime*time.Second.
Szymongib
force-pushed
the
re-controller-tests
branch
from
56715ed to
dd486ca
Compare
akgalwas
approved these changes
Sep 20, 2018
PK85
approved these changes
Sep 20, 2018
clebs
reviewed
Sep 20, 2018
orchestrator.Jenkinsfile
Outdated
| @@ -360,6 +361,8 @@ global.connector_service_tests.version=${versions['tests/connector-service-tests | |||
| global.connector_service_tests.dir=${versions['tests/connector-service-tests'] == env.BRANCH_NAME ? 'pr/' : 'develop/'} | |||
| global.metadata_service_tests.version=${versions['tests/metadata-service-tests']} | |||
| global.metadata_service_tests.dir=${versions['tests/metadata-service-tests'] == env.BRANCH_NAME ? 'pr/' : 'develop/'} | |||
| global.remote-environment-controller-tests.version=${versions['tests/remote-environment-controller-tests']} | |||
There was a problem hiding this comment.
Please use underscores instead of dashes, dashes are not allowed as YAML keys.
See all other components in this list for reference.
clebs
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
First part of #626