Add bindable resources endpoint #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrmiskiewicz
requested review from
akucharska,
aszecowka,
magicmatatjahu,
hudymi,
mjasinski5,
mszostok,
PK85,
pkosiec and
polskikiel
as code owners
2 tasks
piotrmiskiewicz
force-pushed
the
resources-for-all-usagekind
branch
from
d188919 to
af5d46e
Compare
piotrmiskiewicz
added
WIP
area/service-management
piotrmiskiewicz
force-pushed
the
resources-for-all-usagekind
branch
2 times, most recently
from
4d2e1d3 to
98df9c3
Compare
mszostok
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
LGTM, I've tested it on goher cluster and it works like a charm :)
NOTE: IMO we need to inform guys from UI that entry will be returned even if the resources field is empty.
e.g.
{
"data": {
"bindableResources": [
{
"kind": "function",
"resources": []
},
{
"kind": "deployment",
"resources": [
{
"name": "api-controller",
"namespace": "kyma-system"
},
}
so on the UI probably they should not display this entry
| func (rsv *bindableResourcesResolver) ListBindableResources(ctx context.Context, environment string) ([]gqlschema.BindableResourcesOutputItem, error) { | ||
| res, err := rsv.lister.ListResources(environment) | ||
| if err != nil { | ||
| glog.Error(errors.Wrapf(err, "while listing %s for %s `%s` in environment `%s`", pretty.BindableResources, pretty.UsageKind, environment)) |
| ) | ||
|
|
||
| func TestBindableResourcesResolver_ListBindableResources(t *testing.T) { | ||
| svc := automock.NewBindableResourcesLister() |
| dynamicClient usageKindDynamicOperations | ||
| client v1alpha12.ServicecatalogV1alpha1Interface | ||
| informer cache.SharedIndexInformer | ||
| resourceInterface dynamic.Interface |
There was a problem hiding this comment.
maybe more like dynamicCli
| results := make([]gqlschema.BindableResourcesOutputItem, 0) | ||
| usageKinds := svc.informer.GetStore().List() | ||
| for _, item := range usageKinds { | ||
| uk := item.(*v1alpha1.UsageKind) |
There was a problem hiding this comment.
let's add checking the UK casting
uk, ok := item.(*v1alpha1.UsageKind)
thanks to that it will be more robust
piotrmiskiewicz
force-pushed
the
resources-for-all-usagekind
branch
from
98df9c3 to
a5e523f
Compare
piotrmiskiewicz
force-pushed
the
resources-for-all-usagekind
branch
from
a5e523f to
7969186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: