Skip to content

feat: Show module status in busola view #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

a-thaler
Copy link
Collaborator

@a-thaler a-thaler commented Sep 6, 2023

Description

Changes proposed in this pull request:

  • added detail view for telemetry resource to indicate the status

Related Issues and Documents

Closes:

Related issues:

Traceability

  • The PR is linked to a GitHub Issue.
  • New features have a milestone label set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub Issue has a respective area label.
  • The follow-up issues (if any) are linked in the Related Issues section.

Testability

The feature is unit-tested:

  • Yes.
  • No, because unit tests are not needed.
  • No, because of ...

The feature is e2e-tested:

  • Yes.
  • No, because e2e-tests are not needed.
  • No, because of ...

Tests conducted for the PR:

Codebase

  • My code follows the Effective Go style guidelines.
  • The code was planned and designed following the defined architecture and the separation of concerns.
  • The code has sufficient comments, particularly for all hard-to-understand areas.
  • This PR adds value and shows no feature creep.
  • I have augmented the test suite that proves my fix is effective or that my feature works.
  • Adjusted the documentation if the change is user-facing.

@a-thaler a-thaler requested a review from a team as a code owner September 6, 2023 11:03
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2023
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/telemetry and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 6, 2023
@a-thaler
Copy link
Collaborator Author

a-thaler commented Sep 6, 2023

/retest

1 similar comment
@a-thaler
Copy link
Collaborator Author

a-thaler commented Sep 6, 2023

/retest

@kyma-bot kyma-bot merged commit ca3d902 into kyma-project:main Sep 6, 2023
@a-thaler a-thaler deleted the busola branch September 6, 2023 14:49
@a-thaler a-thaler added this to the 0.11.0 milestone Sep 6, 2023
@a-thaler a-thaler added area/manager Manager or module changes and removed area/telemetry labels Oct 6, 2023
@jeffreylimnardy jeffreylimnardy mentioned this pull request Apr 22, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants