Skip to content

feat: LogPipeline HTTP output mTLS support #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 5, 2023

Conversation

dennis-ge
Copy link
Contributor

@dennis-ge dennis-ge commented Sep 29, 2023

Description

Changes proposed in this pull request:

  • mTLS support for LogPipeline HTTP output

Related Issues and Documents

Closes: #366

Traceability

  • The PR is linked to a GitHub Issue.
  • New features have a milestone label set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub Issue has a respective area label.
  • The follow-up issues (if any) are linked in the Related Issues section.

Testability

The feature is unit-tested:

  • Yes.
  • No, because unit tests are not needed.
  • No, because of ...

The feature is e2e-tested:

  • Yes.
  • No, because e2e-tests are not needed.
  • No, because of ...

Tests conducted for the PR:

Codebase

  • My code follows the Effective Go style guidelines.
  • The code was planned and designed following the defined architecture and the separation of concerns.
  • The code has sufficient comments, particularly for all hard-to-understand areas.
  • This PR adds value and shows no feature creep.
  • I have augmented the test suite that proves my fix is effective or that my feature works.
  • Adjusted the documentation if the change is user-facing.

@dennis-ge dennis-ge requested review from a team as code owners September 29, 2023 11:23
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2023
@a-thaler
Copy link
Collaborator

Can you please add a section to the docu https://kyma-project.io/#/telemetry-manager/user/02-logs?id=step-4-add-authentication-details-from-secrets, maybe just another block showing how to do it with client certs, similar as in https://github.com/kyma-project/telemetry-manager/blob/main/docs/user/03-traces.md#step-3b-add-authentication-details-from-secrets

I can see that the traces docu is not getting rendered well on the homepage, maybe you can fix that as well.

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2023
@skhalash skhalash self-assigned this Oct 2, 2023
@skhalash skhalash changed the title feat: Logpipeline HTTP output mTLS support feat: LogPipeline HTTP output mTLS support Oct 2, 2023
spec:
output:
http:
<div tabs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent idea to make the code samples expandable, much better reading experience!

NHingerl
NHingerl previously approved these changes Oct 5, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 5, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 5, 2023
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 5, 2023
@chrkl
Copy link
Contributor

chrkl commented Oct 5, 2023

/retest

1 similar comment
@dennis-ge
Copy link
Contributor Author

/retest

@shorim
Copy link
Contributor

shorim commented Oct 5, 2023

/test pull-telemetry-manager-unit-test

@shorim
Copy link
Contributor

shorim commented Oct 5, 2023

/retest

1 similar comment
@a-thaler
Copy link
Collaborator

a-thaler commented Oct 5, 2023

/retest

@kyma-bot kyma-bot merged commit 9f36474 into kyma-project:main Oct 5, 2023
@a-thaler a-thaler added this to the 1.1.0 milestone Oct 5, 2023
@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/logging area/logs LogPipeline and removed area/logging labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mTLS support for LogPipeline HTTP output
7 participants