-
Notifications
You must be signed in to change notification settings - Fork 161
feat: Support docker image manifest v2 schema1 scanning #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kyujin-cho
merged 2 commits into
main
from
topic/09-06-feat_support_legacy_docker_image_manifest
Sep 30, 2024
Merged
feat: Support docker image manifest v2 schema1 scanning #2815
kyujin-cho
merged 2 commits into
main
from
topic/09-06-feat_support_legacy_docker_image_manifest
Sep 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34ebe36
to
cffeb12
Compare
d101175
to
42141af
Compare
This was referenced Sep 12, 2024
feat: Replace image rescan command's
--local
flag with the local
type ContainerRegistry record
#2665
Merged
cffeb12
to
353ff4e
Compare
42141af
to
83f273a
Compare
353ff4e
to
c8911dd
Compare
83f273a
to
cccaee2
Compare
c8911dd
to
a86f011
Compare
cccaee2
to
f42a5db
Compare
a86f011
to
9ca2260
Compare
f42a5db
to
8eaba4c
Compare
9ca2260
to
3e50364
Compare
8eaba4c
to
1e39787
Compare
3e50364
to
65189eb
Compare
1e39787
to
40922c3
Compare
65189eb
to
679c9e2
Compare
40922c3
to
bc78e16
Compare
679c9e2
to
2a1ca89
Compare
bc78e16
to
e3f3c66
Compare
2a1ca89
to
493be6a
Compare
e3f3c66
to
27d8b1b
Compare
493be6a
to
5a7b249
Compare
27d8b1b
to
3794db3
Compare
5a7b249
to
0d22e40
Compare
3794db3
to
13bbbc3
Compare
Base automatically changed from
topic/08-03-refactor_base_containerregistry_s_scan_tag_and_implement_media_type_docker_manifest_type_handling
to
main
September 30, 2024 15:03
13bbbc3
to
ab9a9f7
Compare
Merge activity
|
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for docker image manifest V2 schema1 for legacy system.
(Fix https://github.com/lablup/giftbox/issues/719)
About docker image manifest V2 schema1 refer to below link:
https://github.com/openshift/docker-distribution/blob/master/docs/spec/manifest-v2-1.md
Test
Manually tested it by following the steps below.
The registry returns a content type of
application/vnd.docker.distribution.manifest.v1+prettyjws
in the response in the/manifests
API.Let's assume there is a locally built image named
stable/bai-python
here.Scan the added container registry.
Check that the image has been correctly updated in the database with the following command.
Checklist: (if applicable)